Monero DevMeeting 2018-10-14

Submitted by aerbax on Sun, 10/14/2018 - 14:11

Highlights

  • The Monero GUI has been tagged for release, but a couple of patches came in at the last minute that need to be applied (one of them involving Ledger integration)
  • Due to the late GUI release, discussions in today's dev meeting are mostly focused on how to better get pre-releases into the hands of testers sooner.
    • Reproducible builds are expected to help with this dramatically.
  • Work is ongoing to upgrade the Monero FFS (Forum Funding System): https://repo.getmonero.org/beardedwarrior/ffs/commits/master

Full Log

1:01 PM <rehrar> Anything of note to report for this past week? You know....besides getting the CLI out?
1:02 PM <rehrar> I know GUI was tagged yesterday, correct? medusa_ dEBRUYNE dsc luigi1111?
1:05 PM <rehrar> speaking of dev activity :P
1:05 PM <rehrar> 12. Anything of note on releases? fluffypony luigi1111w moneromooo?
1:06 PM → MrAntrax joined (~MrAntrax@dhcp-077-250-154-153.chello.nl)
1:06 PM <+hyc> sounds like everyone's asleep
1:06 PM <rehrar> I got kicked by freenode last time I tried to do a mass ping
1:06 PM <medusa_> the GUi is tagged yes...but if there are other issues and if it builds like this i dont know really, sorry
1:06 PM <medusa_> i only see that the build envs are all red ^^
1:06 PM → rbrunner joined (~rbrunner@31-12-138-91-cust-static.fcom.ch)
1:07 PM <rehrar> oy, medusa_.
1:07 PM <rbrunner> Hi people, a little late
1:07 PM <rehrar> That's...a bit scary?
1:07 PM ← MrAntrax left (~MrAntrax@dhcp-077-250-154-153.chello.nl)
1:07 PM <rehrar> Fork is like really soon
1:07 PM → MrAntrax joined (~MrAntrax@dhcp-077-250-154-153.chello.nl)
1:08 PM <rbrunner> Events surrounding the GUI are a bit hectic ...
1:08 PM <rbrunner> It was tagged, but then 2 more PR surfaced that must go in
1:08 PM <rbrunner> One to do with Ledger, I think
1:08 PM <pigeons> looks like PR 1650 builds
1:09 PM <rehrar> well, anything else then?
1:10 PM <iDunk> -- Found OpenSSL: C:/Windows/System32/libcrypto.dll (found version "1.0.2o")
1:10 PM <iDunk> ^ Win32 GUI buildbot
1:10 PM <pigeons> ok we can update that
1:10 PM <iDunk> It shouldn't be there in the first place.
1:11 PM <+hyc> right ^
1:11 PM <pigeons> ok explain after the meeting and i'll try to fix
1:11 PM <MrAntrax> Is there a list on GitHub with small easy issues to contribute too?
1:11 PM <pigeons> MrAntrax: look for Hacktoberfest tag
1:12 PM <MrAntrax> Thanks, six open issues.
1:14 PM ← MrAntrax left (~MrAntrax@dhcp-077-250-154-153.chello.nl)
1:15 PM <rehrar> well, it's been good.
1:15 PM <+hyc> is that a wrap?
1:16 PM <+hyc> just a quick note - #monero-pow channel opened this week for more focused discussion of randomJS, PoW in general
1:16 PM <rehrar> lel, is anything happening?
1:16 PM <rehrar> unless anyone has other topics
1:17 PM <rehrar> I guess I have a topic
1:18 PM <rehrar> how can we do better for next time?
1:18 PM <rehrar> I hate to be that guy, but this is not a good look for Monero.
1:18 PM <+hyc> channel log is in http://highlandsun.com/hyc/monero-pow.txt
1:18 PM <+hyc> rehrar: do what better?
1:18 PM <iDunk> Get more people to build on different platforms and test.
1:18 PM <rbrunner> You mean things like that, perhaps: https://old.reddit.com/r/Monero/comments/9o28zi/new_version_gui_not_available_3_days_before_fork/
1:18 PM <rehrar> four days until fork, tag and binaries for CLI happened very very recently, tag for GUI happened yesterday
1:18 PM <rehrar> iDunk: is that what's needed?
1:19 PM <+hyc> it would certainly help, find issues earlier
1:19 PM <rehrar> If so, I'll make a huge effort to try to market that next time
1:19 PM <iDunk> Well, looks like a lot of issues were found right before tagging.
1:19 PM <+hyc> the reason we've got issues and PRs coming in right at the last minute, people are pulling the release candidates. they should be testing before this point
1:20 PM <iDunk> Exactly.
1:20 PM <rehrar> I understand limited resources, limited developers, and limited testers. I'm not trying to throw shade.
1:20 PM <+hyc> there's also been a lot of build env churn.
1:20 PM <rbrunner> Well, for mere mortals like me it was next to impossible to even build the GUI on Windows until yesterday evening
1:20 PM <+hyc> it looks like a lot of conflicting cmake changes, fix a build on one platform, break it for someone else
1:21 PM <ErCiccione> would help a pre-release tag? since people start to test only when they see the tag, and that's late
1:21 PM <endogenic> rehrar you wanted extreme decentralization... ;)
1:21 PM <medusa_> not focusing on build env is one of the main factors in my view
1:21 PM <medusa_> Prs that break the env shouldnt be allowed to go in in the first place..i know thats painfull
1:21 PM <medusa_> but red envs for days and weeks dont help anyone either
1:21 PM <+hyc> those problems should be going away, as reproducible builds get going
1:22 PM <rbrunner> ... but not yet on Windows, right?
1:22 PM <+hyc> cross-compiled from linux, so should cover windows too
1:22 PM <iDunk> Works fine on Windows (built on Linux).
1:22 PM <rbrunner> Ok, I believe it when I see it :)
1:22 PM <endogenic> ^
1:22 PM <iDunk> ...
1:23 PM <+hyc> I've done lots of windows builds cross-compiled from linux, it's not a problem
1:23 PM <rbrunner> Ok, I think nobody will shed tears for MSYS2
1:23 PM <pigeons> you can test it now rbrunner pull from TheCharlatan's gitian branch
1:23 PM <iDunk> I've crosscompiled Monero for six platforms through depends.
1:23 PM → TheCharlatan joined (~TheCharla@109.236.87.57)
1:23 PM <rbrunner> Sounds interesting.
1:23 PM <rehrar> Yay TheCharlatan is here
1:24 PM <iDunk> Haven't had time for gitian yet.
1:24 PM <sarang> I'm with rehrar... I don't do codebase development per se, but any changes in common practice that lead to earlier reliable builds should be a priority
1:25 PM <+hyc> we could perhaps do a public call for testing when the freeze date approaches. we're well past that now, obviously
1:25 PM <endogenic> yup
1:25 PM <rehrar> we could also perhaps enforce a freeze date
1:25 PM <medusa_> for this we need green env, which we often dont have
1:25 PM <rbrunner> Well, good luck with that code freeze ...
1:25 PM <medusa_> esp on windows
1:26 PM <rbrunner> I think the result would simply be no release out of the door
1:26 PM <rbrunner> At least this time it would have played out that way :)
1:26 PM <rehrar> It's a shame that core team people aren't at these meetings more (hint hint)
1:26 PM <endogenic> rehrar what do you need them for?
1:27 PM ⇐ Osiris1 quit (~Osiris@unaffiliated/osiris1) Ping timeout: 268 seconds
1:27 PM <endogenic> if you point it out..
1:27 PM <rehrar> love and support
1:27 PM <endogenic> but you have that
1:27 PM <rehrar> They're the ones that do the tagging. It'd be valuable to get some of their perspective
1:27 PM → Osiris1 joined (~Osiris@unaffiliated/osiris1)
1:28 PM <endogenic> well imo it's also a community task to provide them guidance on whether to yank a feature bc it's not ready by code freeze
1:28 PM <rehrar> this is also true. And you're correct that it's not valuable to offload responsibility.
1:28 PM <TheCharlatan> When I add a source file to the CMakeLists in common/, will it be linked in all executables? I am trying to ensure that our code has abi compatibility with older glibc versions than what bionic currently provides and would like to define some external glibc functions there.
1:28 PM <rehrar> The sad truth is there is much work to be done, and very few volunteers.
1:28 PM <rehrar> On all fronts.
1:28 PM <endogenic> er i dont believe i quite said that lol
1:29 PM <rbrunner> I think we got it almost right with the features per se: Nobody worked on some bigger things in the GUI up to the last minute this time
1:29 PM <rbrunner> For example
1:30 PM → MrAntrax joined (~MrAntrax@dhcp-077-250-154-153.chello.nl)
New messages since you tabbed out
1:31 PM <+hyc> TheCharlatan: not sure I understand who you're trying to support
1:31 PM <+hyc> and bionic presumably only affects android builds
1:34 PM <rehrar> can we have a brief discussion about the actionable suggestions that have been made by medusa_ and ErCiccione?
1:34 PM <TheCharlatan> so gitian uses the debian debian build tools shipped in a bionic vm image. These tools currently link glibc v27 . This is problematic, because when you compile there and release binaries meant to be run on another system that does not have that specific version, it will not run on the target. This only affects released binaries.
1:35 PM <rehrar> What would it look like from a practical perspective to have priority on keeping env green, even at the cost of merging PRs?
1:35 PM <+hyc> rehrar: C4 says all PRs get merged. it means someone has to watch for breakages and submit reverts.
1:35 PM <+hyc> TheCharlatan: is there anyway we can repackage the gitian env to use older glibc?
1:36 PM <rbrunner> What is C4?
1:36 PM <medusa_> we merge them all yes, but c4 doesnt say really when we have to merge them
1:37 PM <medusa_> code community conribution contract or so ^^
1:37 PM <endogenic> collective code construction contract
1:37 PM <rbrunner> Ok, thanks
1:37 PM <TheCharlatan> r.e. envs, I already discussed with dan miller, that it makes sense to have two different ci envs. One that just ensures compilation, and which should be checked religiously, and one that runs a whole bunch of tests on top of just compiling.
1:37 PM ← MrAntrax left (~MrAntrax@dhcp-077-250-154-153.chello.nl)
1:38 PM <iDunk> Green env achieved, stop all further PRs!
1:38 PM <+moneromooo> I still don't agree with that C4 nonsene.
1:39 PM <ErCiccione> about the code freeze, enforcing that would be very helpful. It's really a mess for me to work on translations while the code is still in development. This time i had to resync all languages twice, and i have the feeling that they would need a third round
1:39 PM <+moneromooo> And the way we've been doing so far is good.
1:39 PM <endogenic> C4 qualifies that they should be correct patches
1:39 PM <rehrar> moneromooo I'm with you. There should (at some point) be a discussion about C4 usage in this project
1:39 PM <+moneromooo> There were, several times.
1:39 PM <rehrar> as it is, it's used and enforced in a scattered manner
1:39 PM <endogenic> which are defined to include not breaking the build
1:39 PM <medusa_> ^
1:39 PM <medusa_> we do c4 but we dont follow its rules
1:40 PM <rbrunner> You don't note breaking Windows builds now while sitting on Windows
1:40 PM <rbrunner> *Linux
1:40 PM <endogenic> code freezes are possible but it simply has to happen by agreement.. and so it's up to you all
1:40 PM <endogenic> rehrar is it ever used inconsistently ?
1:40 PM <TheCharlatan> hyc possible, yes sure. At the same time, I like the newer tools that are available in Bionic, like gcc 7 and 8 . Bitcoin has shown, that is possible to redefine some non compatible libc functions to their older versions.
1:41 PM <rehrar> endogenic: you said it yourself. It's got "keep envs green" and that doesn't happen :D
1:41 PM <rbrunner> There were many such cases: Do something that the Linux compilers likes, but the compiler in MSYS2 does not
1:41 PM <endogenic> it doesn't say keep envs green
1:41 PM <+hyc> TheCharlatan: yes, playing games with header files and linker scripts. would be nice if we can avoid that
1:41 PM <ErCiccione> endogenic: c4 is not enforced at all imho
1:41 PM <endogenic> it's not on maintainers to merge their own patches to keep the env green
1:41 PM <endogenic> ErCiccione: i don't know if the word enforce is even appropriate
1:41 PM <pigeons> Consensus seems to be the depends build system is an important improvement. Let's get fully moved to that, then we can look at things like restricting merges if builds fail
1:41 PM <endogenic> or necessary
1:42 PM <rehrar> this is good pigeons
1:42 PM <+hyc> +1 pigeons
1:42 PM <rehrar> it's actionable and concise
1:42 PM <pigeons> also we are moving to a different repo host probably, so lots of things to complete before enforcing this
1:42 PM <rbrunner> It would be too easy otherwise
1:42 PM <endogenic> ok to move onto something else?
1:42 PM <rehrar> as long as we have one actionable thing, I feel this has been a productive conversation :)
1:42 PM <+moneromooo> Keeping track of build bots would be nice if it weren't completely spammy. That's why I stopped long ago.
1:42 PM <ErCiccione> endogenic: well, it's a set of rules all contributors should follow. If they are not followed, the community/developers should enforce that, or what do we have it for?
1:43 PM <medusa_> maybe we should just do nightlies and watch does moneromooo
1:43 PM <+moneromooo> I do not understand that.
1:43 PM <medusa_> not each pr, thats insane yes
1:43 PM → orph- joined (~orph@136.25.187.29)
1:43 PM <rehrar> I would like to pause here for a moment and acknowledge that even though not everything is going how many would like, this is the work of volunteers and passionate people, and I would like to extend gratitude (at least from myself) to those who work on this.
1:44 PM <+moneromooo> Ah. Each PR is the point of it, so they can be fixed before merging.
1:44 PM <endogenic> thanks rehrar
1:44 PM <rbrunner> Right, rehrar
1:44 PM <rehrar> We're a big, dorky family with quirks and friction aplenty, but we're in this together.
1:45 PM <rehrar> Anyways, enough sappy talk.
1:45 PM <rehrar> Any other topics of discussion?
1:45 PM <+hyc> maybe we can setup a schedule to poll for merges 6x/day or something. checking each PR is good, but doesn't detect merge conflicts
1:45 PM <endogenic> rehrar hmm
1:45 PM <i2p-relay> {-oneiric_} yeah, much love to all the devs and community for making monero awesome
1:45 PM <ErCiccione> it's like a family with only grumpy uncles /s
1:47 PM <endogenic> so the ffs backend repo is public. so anyone can contribute to it and test it and we can start adding our own feature ideas. https://repo.getmonero.org/beardedwarrior/ffs/commits/master
1:47 PM <rehrar> yes! Devin is doing good work on that.
1:47 PM <endogenic> now maybe we'll have less vague accusations that the core team is blocking progress on the ffs or whatever it was
1:48 PM <endogenic> s/less/fewer/
1:48 PM <rehrar> We'll have things like QR codes by default, a feed so anyone can access the different proposals in the different stages
1:48 PM <rehrar> A lot of exciting stuff coming along there.
1:49 PM <rehrar> Alright, anything else?
1:50 PM <rehrar> We'll go ahead and wrap there then. Discussion on any topic can, of course, continue outside of the meeting. Thanks all!
Tags