DevMeeting 2018-03-18

From Monerobase
Jump to: navigation, search

Highlights[ ]

  • To allow some additional time to test all of the new features, the next Monero release has been pushed to ~April 6th: https://github.com/monero-project/monero/pull/3424
    • Version 0.12 "Lithium Luna"
    • The release is expected to be tagged and ready for testing this week.
  • v0.12 "Major" Features
    • MultiSig
    • SubAddresses
    • Default Ring Size increase from 5 to 7
    • Proof of Work changes to combat ASIC's
    • Initial hardware wallet support for Ledger
    • Key reuse mitigations
  • A Dark theme for the official GUI should be finalized this week.


Full Log[ ]

1:02 PM <@fluffypony> meeting time
1:03 PM <@fluffypony> 1. Greetings
1:03 PM <KnifeOfPi> hello!
1:03 PM <@ArticMine> hi
1:03 PM <rbrunner> Hoi zäme
1:03 PM <xmrscott[m]> Salutations
1:04 PM <@fluffypony> binaryFate luigi1111 luigi1111w smooth hyc moneromooo cryptochangement cslashm dEBRUYNE ErCiccione gingeropolous
1:04 PM <KnifeOfPi> suraeNoether sarang
1:04 PM <suraeNoether> howdy~
1:04 PM <ErCiccione> Hi!
1:04 PM <cryptochangement> hello
1:04 PM <medusa_> hi
1:05 PM <@fluffypony> iDunk: IPGlider JollyMort[m] stoffu NoodleDoodle pigeons redfish whoever else
1:05 PM <KnifeOfPi> rehrar
1:05 PM <anonimal> Hi
1:05 PM <iDunk> Hi
1:05 PM <dEBRUYNE> hi
1:05 PM → +monero (voiced) joined  
1:05 PM <+monero> [monero] anonimal opened pull request #3431: README: add instructions for cloning / submodules (master...README) https://git.io/vx3cU
1:05 PM → ComatoseCarrot joined  ← +monero left  
1:06 PM <ComatoseCarrot> Howdy
1:07 PM <@fluffypony> 2. Brief review of what's been completed since the previous meeting
1:08 PM <gingeropolous> hi
1:08 PM <suraeNoether> I wrote a thing: https://github.com/b-g-goodell/research-lab/blob/in-prep/publications/bulletins/MRL-0007-multisig/draft/MRL-0007-multisig.pdf
1:08 PM <suraeNoether> seekin feedback, especially on proofs
1:08 PM <KnifeOfPi> a wonderful thing it seems
1:08 PM <@fluffypony> awesome
1:08 PM <@fluffypony> also we merged pretty much everything we need for v0.12
1:09 PM <@fluffypony> so final checks before we tag
1:09 PM <@fluffypony> I'd imagine we tag tomorrow if all goes well
1:09 PM <anonimal> #3431?
1:09 PM <medusa_> so the height got moved by..2 weeks ?
1:09 PM <anonimal> Not urgent, and anyone cloning the repo will probably be on master anyway.
1:09 PM <@fluffypony> anonimal: we already branched so you'd have to PR to the branch
1:09 PM <@fluffypony> medusa_: yes - everyone wanted to push it
1:10 PM <@fluffypony> I wanted to push it to the anniversary date
1:10 PM <@fluffypony> but alas
1:10 PM <@luigi1111> Hey it was my suggestion
1:10 PM <@fluffypony> it seems luigi1111 and I are the only ones who are serendipitous :-P
1:10 PM → +monero (voiced) joined  
1:10 PM <+monero> [monero] anonimal closed pull request #3431: README: add instructions for cloning / submodules (master...README) https://git.io/vx3cU
1:10 PM ← +monero left (~monero@coreteam.getmonero.org)
1:11 PM <KnifeOfPi> what happens when people accuse us of procrastination? "march hard fork isn't in march anymore"
1:11 PM <@fluffypony> anonimal: lol no leave the master one open too :)
1:11 PM <@luigi1111> We move fork to anniversary in future
1:11 PM <@fluffypony> KnifeOfPi: I think this is going to be a permanent change to April / October
1:11 PM — anonimal facepalms
1:11 PM <anonimal> Sorry
1:11 PM <@fluffypony> yes what luigi1111 said
1:11 PM <cryptochangement> I see #3424 was merged, so I guess we are pushed back a week now?
1:11 PM <@fluffypony> cryptochangement: yes
1:11 PM <@luigi1111> This is a sorta asap fork for pow
1:11 PM <@luigi1111> Not asap
1:11 PM <@luigi1111> But soon
1:11 PM <@ArticMine> Do we have a block number / date?
1:11 PM <cryptochangement> an extra week isnt going to hurt anybody lol
1:12 PM <cryptochangement> april 5
1:12 PM <dEBRUYNE> It's 9 days actually
1:12 PM <@luigi1111> Or 11
1:12 PM <cryptochangement> 1546500 ArticMine
1:12 PM <gingeropolous> well good thing we can do math
1:12 PM <+moneromooo> 1546000
1:12 PM <@luigi1111> Some of us can some of the time
1:12 PM → +monero (voiced) joined  
1:12 PM <+monero> [monero] anonimal reopened pull request #3431: README: add instructions for cloning / submodules (master...README) https://git.io/vx3cU
1:12 PM ← +monero left (~monero@coreteam.getmonero.org)
1:12 PM <iDunk> 1546000
1:12 PM <cryptochangement> oops I just noticed that haha
1:12 PM <@fluffypony> lol
1:12 PM <@fluffypony> well I guess we really are amateurs after all :-P
1:12 PM <@fluffypony> so that pretty much covers 3. March hardfork items + code freeze
1:13 PM <@fluffypony> so I guess 4. Code + ticket discussion / Q & A
1:13 PM <dEBRUYNE> https://github.com/monero-project/monero/pull/3424 <= Title is wrong there fwiw. Code says 1546000
1:13 PM <rbrunner> Yes, that happens with 24 hour programming shifts
1:13 PM <rbrunner> just before HF's
1:13 PM <rbrunner> .)
1:13 PM <@fluffypony> dEBRUYNE: "the truth is in the code"
1:14 PM <+hyc> sourcecode never lies
1:14 PM <medusa_> so when do we plan to build monerod more or less ?
1:14 PM <@fluffypony> so I think the next week or two is full on last-minute-brokenness-checks for this extremely-last-minute-fork
1:14 PM <KnifeOfPi> just to confirm for pinkphloid: to comply with the HF, wallets just need to set min ring size to 7 and sort inputs, right?
1:15 PM <@fluffypony> medusa_: tag and release in the next day or so
1:16 PM → +monero (voiced) joined  
1:16 PM <+monero> [monero] anonimal opened pull request #3432: README: add instructions for cloning / submodules (release-v0.12...README) https://git.io/vx3cp
1:16 PM ← +monero left (~monero@coreteam.getmonero.org)
1:16 PM <@luigi1111> KnifeOfPi: yes
1:16 PM <KnifeOfPi> and for clarity, how is this input-sorting to be done? i'm not familiar
1:17 PM <@luigi1111> Interpret key image as integer
1:17 PM <@luigi1111> I think
1:17 PM <KnifeOfPi> ah, i see
1:17 PM <+moneromooo> big endian
1:17 PM <KnifeOfPi> so it's similar to BIP69?
1:17 PM <@fluffypony> sort by the recipient's name
1:17 PM <@fluffypony> :-P
1:17 PM <KnifeOfPi> LOL
1:17 PM <dsc_> I'd like to talk about the GUI black theme redesign
1:18 PM <@fluffypony> dsc_: please do
1:18 PM <dsc_> Planning to merge it into master this week - possibly tomorow.
1:18 PM <dsc_> Since it's almost finished :P
1:19 PM <KnifeOfPi> good work !
1:19 PM <dsc_> I still have a week left of vacation too, so any bugs testers come up with, I could look at.
1:19 PM <Slack_1> *needkovri90 lurks
1:19 PM <dsc_> ~end update~
1:19 PM <@fluffypony> we can push the GUI out a little later in the week
1:19 PM <@fluffypony> to give time for that
1:19 PM <dsc_> fluffypony: sure
1:19 PM <cryptochangement> dope
1:19 PM <cryptochangement> would that then complete you FFS?
1:19 PM <@fluffypony> rbrunner: what needs to be done on the installer side?
1:19 PM <dsc_> cryptochangement: Ill complete the FFS when it makes it into the bins
1:20 PM <medusa_> we have 1 new dll rbrunner, not sure why but it is how it is
1:20 PM <rbrunner> A few little things. I am working on it.
1:20 PM <medusa_> its not part of win_deploy helper script yet unfortunately
1:20 PM <rbrunner> Still have to sort out some DLL hell with my installation
1:20 PM <rbrunner> to really check
1:21 PM <rbrunner> libssp-0.dll, I think
1:21 PM <medusa_> yes!
1:21 PM <rbrunner> stack protectino related
1:21 PM <rbrunner> and there are now 5 ICU DLLs, but that's about it
1:22 PM <rbrunner> I hope I can finish and push tomorrow
1:24 PM <ErCiccione> so when code freeze for the GUI? end of next week?
1:24 PM <@fluffypony> ErCiccione: whenever the GUI workgroup say they're ready
1:25 PM <@binaryFate> poor ErCiccione never getting a code freeze date :P
1:25 PM <KnifeOfPi> lol
1:25 PM <ErCiccione> ok, i only need few days for 1184
1:25 PM <medusa_> we got a few more days, depends how the cli release goes too, its dynamic
1:26 PM <KnifeOfPi> when moon? when lambo? when codefreeze?
1:26 PM <ErCiccione> yes binaryfate, that was my weekly try :P
1:26 PM <rbrunner> We are certainly all very "agile" here
1:27 PM <@fluffypony> moneromooo is our scrum master
1:27 PM <medusa_> ^^
1:28 PM <@fluffypony> ok so
1:28 PM <@fluffypony> 5. Any additional meeting items
1:28 PM <TheCharlatan> Is there are a reason for keeping the cli dynamic?
1:28 PM <gingeropolous> i was wondering if we could discuss our release / hard fork schedule?
1:28 PM <iDunk> I used to build a fully static GUI 1-1.5 years ago.
1:28 PM <medusa_> no i didnt mean the build TheCharlatan :D just that issues can arise out of nowehere, so the actual date of the dreeze isnt known rly
1:29 PM <medusa_> sorry im confused
1:29 PM <iDunk> But, IIRC, the opensource Qt version license forbids statically linking Qt libs.
1:29 PM <TheCharlatan> lol, if so, bitcoin would operate illegally since years.
1:30 PM <iDunk> We'd probably need to buy the license.
1:30 PM <rbrunner> The CLI *is* statically linked?
1:30 PM <rbrunner> But not the GUI
1:30 PM <pigeons> you can build the cli statically linked or link it dynamically to shared libs
1:30 PM <iDunk> Ah, yes, the cli is static.
1:30 PM → doubleyousee23 joined (~doubleyou@cpe-72-227-89-58.ne.res.rr.com)
1:31 PM <@ArticMine> There is no license problem with statically linking to QT libs. The resulting license would be LGPL v3
1:31 PM <Slack_1> <needkovri90> Do we know the status of the Monero Observer and related FFS?
1:31 PM <anonimal> fluffypony: I don't want to ruin the icing on the cake of #3429 with #3432. Are more commits expected to come for branch release-v0.12 (like for #3401)?
1:31 PM <Slack_1> <needkovri90> Hasnt been updated for a while, and I link it in the xmrtrader daily threads
1:31 PM <gingeropolous> basically, it seems we pack a lot into releases. And because of our hard forks, we've ended up cutting it close multiple times now, for this that or the other reason. Would there be any benefit to focusing on consensus critical stuff for hard fork releases, and adding soft-fork stuff in between?
1:31 PM <@fluffypony> anonimal: we can have extra commits to the branch, don't stress about it
1:31 PM <Slack_1> <needkovri90> If anyone has info, I would like to relay it to the subreddit.
1:31 PM <KnifeOfPi_> needmoney90: i think monerooby_doo is busy with his family
1:31 PM <anonimal> k
1:31 PM <KnifeOfPi_> but monero observer should be back soon
1:32 PM <@fluffypony> gingeropolous: I think the problem are the unknown unknowns
1:32 PM <Slack_1> <needkovri90> Thanks KoP
1:32 PM <KnifeOfPi_> you’re welcome
1:32 PM <TheCharlatan> iDunk static linking qt should be fine as long as the licence used is gpl compatible.
1:32 PM <@fluffypony> eg. we wouldn't have picked a fork point in December because of the risk
1:33 PM <iDunk> I must have misread something then.
1:33 PM <gingeropolous> fluffypony, true. from my perspective, it would just seem easier if, for instance, all we had to worry about breaking this release was the PoW and ringsize bump
1:33 PM <gingeropolous> those are the consensus critical things.
1:33 PM <gingeropolous> unless the sorted input one is too.. which it seems to be
1:33 PM <@fluffypony> gingeropolous: we could
1:34 PM <+moneromooo> It'll just add more work.
1:34 PM <@fluffypony> we could've put out a point release in Jan but there weren't any critical bug fixes
1:34 PM <@fluffypony> what moneromooo said
1:34 PM <gingeropolous> yeah
1:34 PM <@fluffypony> if we put out a release based off master every month that's just going to create so much more work
1:34 PM <gingeropolous> if we had a mid fork release thing, then it'd be a whole nother round of the release work
1:34 PM <@fluffypony> because then there are bugs and urgent fixes etc. etc.
1:35 PM thrmo → bearrorist
1:35 PM <+moneromooo> The coming release is special due to the unexpected need for a PoW change and key reuse mitigations.
1:35 PM <+moneromooo> The next one is not expected to have those wrenches thrown at it.
1:36 PM <@fluffypony> but it'll have other wrenches :-P
1:36 PM <gingeropolous> well, i guess the thought is to partition efforts into consensus critical and non-consensus
1:36 PM <cryptochangement> but there is always more unexpected to expect :P
1:36 PM <+moneromooo> Maybe... :)
1:36 PM <gingeropolous> but i guess that happens organically
1:37 PM <+moneromooo> So what would you do exactly ? Get 0.11.1.0, merge just PoW change and ring size bump, and release that ?
1:37 PM <+moneromooo> Then... another release with all the other stuff ?
1:37 PM <gingeropolous> yeah, like 3 months ago
1:37 PM <gingeropolous> subaddresses... whatever else happened
1:38 PM <KnifeOfPi_> multisig
1:38 PM <+moneromooo> 3 months ago would have been useless since we just recently merged the final PoW changes.
1:38 PM <gingeropolous> no, i mean the soft forky stuff thats been sitting unused by testers
1:38 PM <gingeropolous> testers i.e., users
1:38 PM <+moneromooo> Well, if someone wants to test, they don't need a release.
1:38 PM → p0nziph0ne joined (p0nziph0ne@gateway/vpn/privateinternetaccess/p0nziph0ne)
1:39 PM <gingeropolous> well indeed ... but more stuff gets found when more ppl use it
1:39 PM <TheCharlatan> if tests are run for every pr, ci is run on all platforms and everything can be cross compiled, it should be possible to have higher frequency releases, right?
1:39 PM <+moneromooo> It'd be nice, but it requires more pony time.
1:39 PM <@fluffypony> TheCharlatan: that already happens
1:39 PM <@fluffypony> gingeropolous: but again, 3 months ago it was unstable
1:39 PM <gingeropolous> simple. clone pony
1:39 PM <@fluffypony> so you release
1:39 PM <+moneromooo> Do it.
1:40 PM <@fluffypony> and then everyone is trying to fix brokenness and merge PRs to master and branch
1:40 PM <+moneromooo> Dolly the sheep, and not Fluffy the pony...
1:40 PM <+moneromooo> now*
1:40 PM <@fluffypony> I think that a nice cadence is tag-and-release 3 months before forkheight
1:41 PM <@fluffypony> and then testers have bins and can test
1:41 PM <KnifeOfPi_> tick-tock
1:41 PM <KnifeOfPi_> basically
1:41 PM <iDunk> TheCharlatan: can you make Depends not destructive to the current build system ?
1:41 PM <@fluffypony> and emergency things like PoW change can be put into the branch
1:41 PM <+moneromooo> Except... 3 months is a bit much now that we have to poke at PoW.
1:41 PM <gingeropolous> ^^
1:41 PM <+moneromooo> That gives evildoers 9 months.
1:41 PM <cryptochangement> wasn't the idea of a 3 month code freeze brought up in september? whatever happened to that?
1:42 PM <gingeropolous> hence, splitting consensus critical from feature stuff
1:42 PM <+moneromooo> What does that have to do with it...
1:42 PM <rbrunner> it ... melted away?
1:42 PM <@fluffypony> cryptochangement: we were going to tag and release in December
1:42 PM <@fluffypony> then we stalled that to make a decision on Bulletproofs
1:42 PM <@fluffypony> and then the PoW thing happened
1:42 PM <cryptochangement> ah ok
1:42 PM <TheCharlatan> iDunk sure, I just messed up some things along the way. Probably commited a Makefile, that I was not supposed to commit.
1:42 PM <gingeropolous> so stuff just needs to stop happening, and then we'll be on schedule
1:42 PM <@fluffypony> it's an unusual set of circumstances
1:43 PM <@fluffypony> gingeropolous: lol
1:43 PM <gingeropolous> i'll make the PR
1:43 PM ⇐ msvb-lab quit (~michael@x55b54176.dyn.telefonica.de) Ping timeout: 256 seconds
1:43 PM <@fluffypony> but yes
1:43 PM <gingeropolous> well, just wanted to kick the tires on it.
1:43 PM <@fluffypony> from this I'd like us to go back to 3mths
1:44 PM <@binaryFate> "go back" did we ever do it?
1:44 PM <medusa_> well together with the pint releases, frequency can be quite high
1:44 PM <@fluffypony> moneromooo: if we merged the PoW changes 3 months before fork point that's fine, tho
1:44 PM <@fluffypony> binaryFate: go back to the idea of 3 months I mean
1:45 PM <@fluffypony> ok we can continue this discussion later, I think we have a solid path forward
1:45 PM <@fluffypony> 6. Confirm next meeting date/time
1:46 PM <+moneromooo> You'd want them to be in github for a bit though, so people like schernyk (IIRC) can see it.
1:46 PM <+moneromooo> So that means PoW changes known before 3 months early.
1:46 PM <@fluffypony> is everyone ok for next Sunday? the once-a-week cadence is nice until fork
1:46 PM <@fluffypony> moneromooo: good point
1:46 PM <@ArticMine> Sure
1:46 PM <@fluffypony> moneromooo: let's think about it and figure it out
1:46 PM — anonimal ok
1:46 PM <rbrunner> Ok
1:46 PM <@fluffypony> thanks for the meeting guys